memory leak in subset demo #36
Comments
|
This problem is indeed serious. |
|
@papandreou feel free to consider this isn't issue in your codes as the demo was based on yours apparently. If you are destroying whole wasm machine it probably won't matter much yet better to have this also. Thanks! |
papandreou
added a commit
to papandreou/subset-font
that referenced
this issue
Apr 14, 2021
|
@ebraminio, thanks for the ping. I'm not destroying the whole wasm machine, and the heap gets reused between calls to the subsetting. Fixed in papandreou/subset-font@1170630 |
ebraminio
added a commit
that referenced
this issue
Apr 14, 2021
No need to create an input set, just add it to the one input object has. Related to #36
|
Turned out it one more issue which is fixed by d8d54ad Went for fixing it in subset-font and found some other issue added on: papandreou/subset-font#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In "https://github.com/harfbuzz/harfbuzzjs/blob/master/subset/test.js", the fontBuffer created by exports.malloc is not destroyed. The memory should be released by call exports.free method.
The text was updated successfully, but these errors were encountered: