Adding subset result detection to node.js example #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yisibl
force-pushed
the
check-subset-byte-length
branch
from
d4ccb72 to
5a8e34b
Compare
yisibl
force-pushed
the
check-subset-byte-length
branch
from
5a8e34b to
a63b669
Compare
ebraminio
approved these changes
Mar 19, 2023
khaledhosny
reviewed
Mar 21, 2023
| exports.hb_set_add(unicode_set, 'b'.charCodeAt(0)); | ||
| exports.hb_set_add(unicode_set, 'c'.charCodeAt(0)); | ||
| for (const text of SUBSET_TEXT) { | ||
| exports.hb_set_add(unicode_set, text.charCodeAt(0)); |
There was a problem hiding this comment.
Though it is safe for this example (the text is all ASCII), charCodeAt gives UTF-16 code units (including surrogate pairs), you should use codePointAt instead.
There was a problem hiding this comment.
Thanks for the correction, let me fix it.
yisibl
added a commit
to yisibl/harfbuzzjs
that referenced
this pull request
Mar 21, 2023
@khaledhosny says: > `charCodeAt` gives UTF-16 code units (including surrogate pairs), you should use `codePointAt` instead. > harfbuzz#73 (review)
yisibl
added a commit
to yisibl/harfbuzzjs
that referenced
this pull request
Mar 21, 2023
@khaledhosny says: > `charCodeAt` gives UTF-16 code units (including surrogate pairs), you should use `codePointAt` instead. > harfbuzz#73 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.