Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly modify page payload for init mode #29

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: correctly modify page payload for init mode #29

merged 1 commit into from
May 25, 2023

Conversation

jbmolle
Copy link
Contributor

@jbmolle jbmolle commented May 25, 2023

Description

This PR fixes #24
Nuxt Core Runtime Nitro Renderer has now 2 different functions renderPayloadScript and renderPayloadJsonScript.
When using renderPayloadJsonScript, isPageSSR returns false when it should be true and 'init' mode is not working.

Linked Issues

#24

@harlan-zw harlan-zw changed the title update: Assert isPageSSR with __NUXT_DATA__ JSON payload fix: correctly modify page payload for init mode May 25, 2023
@harlan-zw harlan-zw merged commit 9f1fa2d into harlan-zw:main May 25, 2023
@harlan-zw
Copy link
Owner

Nice catch! Thanks for the help 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'init' mode not working at all
2 participants