Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: canonicalQueryWhitelist #282

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

harlan-zw
Copy link
Owner

@harlan-zw harlan-zw commented Aug 6, 2024

🔗 Linked issue

#276

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds support for having query params in the canonical URL, this is important when using query param pagination or searching.

Default whitelist:

[
  'page',
  'sort',
  'filter',
  'search',
  'q',
  'category',
  'tag',
],

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-seo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:51pm

@harlan-zw harlan-zw merged commit 568c2b7 into main Aug 6, 2024
3 checks passed
@harlan-zw harlan-zw deleted the feat/canonical-query-whitelist branch August 6, 2024 23:52
@ronenteva
Copy link

Thanks for the update!
I suggest marking such changes as breaking, as these new defaults have SEO implications.

@harlan-zw
Copy link
Owner Author

harlan-zw commented Aug 7, 2024

Every RC update is potentially breaking, I should have left it as a beta but too late for that 😕

Trying to get it stable asap

The seo implications of this should be negligible though, these are the defaults used by more popular SEO integrations

tobiasdiez referenced this pull request in JabRef/JabRefOnline Aug 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@nuxtjs/seo](https://nuxtseo.com/)
([source](https://github.com/harlan-zw/nuxt-seo)) | [`2.0.0-rc.16` ->
`2.0.0-rc.18`](https://renovatebot.com/diffs/npm/@nuxtjs%2fseo/2.0.0-rc.16/2.0.0-rc.18)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nuxtjs%2fseo/2.0.0-rc.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nuxtjs%2fseo/2.0.0-rc.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nuxtjs%2fseo/2.0.0-rc.16/2.0.0-rc.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nuxtjs%2fseo/2.0.0-rc.16/2.0.0-rc.18?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@pinia/nuxt](https://github.com/vuejs/pinia/tree/v2/packages/nuxt#readme)
([source](https://github.com/vuejs/pinia)) | [`0.5.2` ->
`0.5.3`](https://renovatebot.com/diffs/npm/@pinia%2fnuxt/0.5.2/0.5.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/@pinia%2fnuxt/0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@pinia%2fnuxt/0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@pinia%2fnuxt/0.5.2/0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@pinia%2fnuxt/0.5.2/0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pinia](https://github.com/vuejs/pinia) | [`2.2.0` ->
`2.2.1`](https://renovatebot.com/diffs/npm/pinia/2.2.0/2.2.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pinia/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pinia/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pinia/2.2.0/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pinia/2.2.0/2.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [typescript](https://www.typescriptlang.org/)
([source](https://github.com/Microsoft/TypeScript)) | [`5.5.3` ->
`5.5.4`](https://renovatebot.com/diffs/npm/typescript/5.5.3/5.5.4) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/typescript/5.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/typescript/5.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/typescript/5.5.3/5.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/typescript/5.5.3/5.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [vite](https://vitejs.dev)
([source](https://github.com/vitejs/vite/tree/HEAD/packages/vite)) |
[`5.3.5` -> `5.4.0`](https://renovatebot.com/diffs/npm/vite/5.3.5/5.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/vite/5.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite/5.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite/5.3.5/5.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite/5.3.5/5.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>harlan-zw/nuxt-seo (@&#8203;nuxtjs/seo)</summary>

###
[`v2.0.0-rc.18`](https://github.com/harlan-zw/nuxt-seo/releases/tag/v2.0.0-rc.18)

[Compare
Source](https://github.com/harlan-zw/nuxt-seo/compare/v2.0.0-rc.17...v2.0.0-rc.18)

#####    🐞 Bug Fixes

- Wait for i18n plugin, handle fallback  -  by
[@&#8203;harlan-zw](https://github.com/harlan-zw)
[<samp>(81163)</samp>](https://github.com/harlan-zw/nuxt-seo/commit/8116353)

#####     [View changes on
GitHub](https://github.com/harlan-zw/nuxt-seo/compare/v2.0.0-rc.17...v2.0.0-rc.18)

###
[`v2.0.0-rc.17`](https://github.com/harlan-zw/nuxt-seo/releases/tag/v2.0.0-rc.17)

[Compare
Source](https://github.com/harlan-zw/nuxt-seo/compare/v2.0.0-rc.16...v2.0.0-rc.17)

#####    🚨 Breaking Changes

- Bump `@nuxtjs/sitemap` v6 beta  -  by
[@&#8203;harlan-zw](https://github.com/harlan-zw)
[<samp>(a6204)</samp>](https://github.com/harlan-zw/nuxt-seo/commit/a620429).

⚠️ Please see
[https://github.com/nuxt-modules/sitemap/pull/320](https://github.com/nuxt-modules/sitemap/pull/320)
if you have submitted multi-sitemap URLS in Google Search Console as the
paths have changed.

#####    🚀 Features

- `canonicalQueryWhitelist`  -  by
[@&#8203;harlan-zw](https://github.com/harlan-zw) in
[https://github.com/harlan-zw/nuxt-seo/issues/282](https://github.com/harlan-zw/nuxt-seo/issues/282)
[<samp>(568c2)</samp>](https://github.com/harlan-zw/nuxt-seo/commit/568c2b7)

#####    🐞 Bug Fixes

- Missing nuxt app context when using `useBreadcrumbItems`  -  by
[@&#8203;harlan-zw](https://github.com/harlan-zw)
[<samp>(2005a)</samp>](https://github.com/harlan-zw/nuxt-seo/commit/2005a29)
- Reactive `lang` when using Nuxt I18n  -  by
[@&#8203;harlan-zw](https://github.com/harlan-zw)
[<samp>(58e4f)</samp>](https://github.com/harlan-zw/nuxt-seo/commit/58e4f3e)

#####     [View changes on
GitHub](https://github.com/harlan-zw/nuxt-seo/compare/v2.0.0-rc.16...v2.0.0-rc.17)

</details>

<details>
<summary>vuejs/pinia (@&#8203;pinia/nuxt)</summary>

### [`v0.5.3`](https://github.com/vuejs/pinia/releases/tag/v0.5.3)

[Compare
Source](https://github.com/vuejs/pinia/compare/@pinia/nuxt@0.5.2...@pinia/nuxt@0.5.3)

Please refer to
[CHANGELOG.md](https://github.com/posva/pinia/blob/v1/CHANGELOG.md)
for details.

</details>

<details>
<summary>Microsoft/TypeScript (typescript)</summary>

###
[`v5.5.4`](https://github.com/Microsoft/TypeScript/compare/v5.5.3...c8a7d589e647e19c94150d9892909f3aa93e48eb)

[Compare
Source](https://github.com/Microsoft/TypeScript/compare/v5.5.3...v5.5.4)

</details>

<details>
<summary>vitejs/vite (vite)</summary>

###
[`v5.4.0`](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#540-2024-08-07)

- fix(build): windows platform build output path error
([#&#8203;17818](https://github.com/vitejs/vite/issues/17818))
([6ae0615](https://github.com/vitejs/vite/commit/6ae0615416762dd1b89393316308cf8edf115c34)),
closes [#&#8203;17818](https://github.com/vitejs/vite/issues/17818)
- fix(deps): update launch-editor to consume fix for windows paths
([#&#8203;17828](https://github.com/vitejs/vite/issues/17828))
([cf2f90d](https://github.com/vitejs/vite/commit/cf2f90d4b9f9b16b8009b0f9d0d9f7e71e98c54d)),
closes [#&#8203;17828](https://github.com/vitejs/vite/issues/17828)
- fix(ssr): fix `global` variable name conflict
([#&#8203;17809](https://github.com/vitejs/vite/issues/17809))
([6aa2206](https://github.com/vitejs/vite/commit/6aa220607b4f5457c1ef9ff68d75885a9abbdaf6)),
closes [#&#8203;17809](https://github.com/vitejs/vite/issues/17809)
- fix(worker): fix `importScripts` injection breaking iife code
([#&#8203;17827](https://github.com/vitejs/vite/issues/17827))
([bb4ba9f](https://github.com/vitejs/vite/commit/bb4ba9f448da01782f585369f80c4517da087000)),
closes [#&#8203;17827](https://github.com/vitejs/vite/issues/17827)
- chore: bump typescript-eslint to v8
([#&#8203;17624](https://github.com/vitejs/vite/issues/17624))
([d1891fd](https://github.com/vitejs/vite/commit/d1891fda026d27f53409dec97e156a59da609196)),
closes [#&#8203;17624](https://github.com/vitejs/vite/issues/17624)
- chore(deps): update all non-major dependencies
([#&#8203;17820](https://github.com/vitejs/vite/issues/17820))
([bb2f8bb](https://github.com/vitejs/vite/commit/bb2f8bb55fdd64e4f16831ff98921c221a5e734a)),
closes [#&#8203;17820](https://github.com/vitejs/vite/issues/17820)
- perf(ssr): do a single-pass over AST with node cache arrays
([#&#8203;17812](https://github.com/vitejs/vite/issues/17812))
([81327eb](https://github.com/vitejs/vite/commit/81327eb980c308474a586a9cb9c0c5fff10eba34)),
closes [#&#8203;17812](https://github.com/vitejs/vite/issues/17812)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the
month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/JabRef/JabRefOnline).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants