Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumbs): support computed overrides #331

Merged
merged 1 commit into from
Oct 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/runtime/nuxt/composables/useBreadcrumbItems.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export interface BreadcrumbProps {
/**
* Override any of the breadcrumb items based on the index.
*/
overrides?: (BreadcrumbItemProps | false | undefined)[]
overrides?: MaybeRefOrGetter<(BreadcrumbItemProps | false | undefined)[]>
/**
* Should the schema.org breadcrumb be generated.
* @default true
Expand Down Expand Up @@ -127,7 +127,7 @@ export function useBreadcrumbItems(options: BreadcrumbProps = {}) {
}
const current = withoutQuery(withoutTrailingSlash(toValue(options.path || router.currentRoute.value?.path) || rootNode))
// apply overrides
const overrides = options.overrides || []
const overrides = toValue(options.overrides || []);
const segments = pathBreadcrumbSegments(current, rootNode)
.map((path, index) => {
let item = <BreadcrumbItemProps> {
Expand Down