[consensus][viewchange] fix total power of signers in IsQuorumAchieved for view change

[gupadhyaya]

fixes #2741

didn't want to completely get rid of quorum.ViewChange, as signers total voting power information could be useful. Further, removing the option quorum.ViewChange may lead to regression.

[fxfactorial]

This is a change of original view change logic. Dig deeper into the git commit history of initial usage of submitvote to see this was original value used. I also was confused by this initially but didn't want to deviate from original code.

[gupadhyaya]

Went back in history... looks like in the original OnViewChange method, the the vote was still added to commitSigs, but never used, instead viewIDSigs was used. See below:

consensus.viewIDSigs[senderKey.SerializeToHexStr()] = recvMsg.ViewidSig
...
if len(consensus.viewIDSigs) >= consensus.Quorum() {
    ...
    consensus.commitSigs[consensus.PubKey.SerializeToHexStr()] = consensus.priKey.SignHash(commitPayload)

History:

commit where view change was working: ddb2076cee19294b14a8b814acbff5f48d5bfc2e (without staking refactor)
commit that broke view change: 9f00923ac344d297f5347958f38b909e1656e95a (staking refactor)
commit that fixed it by changing the decider to mask: 925afa59eea2a1b1f7e98d8fcf4df0d217aeb9fa

when @fxfactorial refactored to IsQuorumAchieved I believe it broke view change, hence @chaosma changed the logic to use IsQuorumAchievedByMask. This explains why view change was working correctly.

Right now the code still uses IsQuorumAchievedByMask and not IsQuorumAchieved, hence view change works as expected.

[rlan35]

if consensus.Decider.IsQuorumAchieved(quorum.ViewChange) {
    consensus.getLogger().Debug().
        Int64("have", consensus.Decider.SignersCount(quorum.ViewChange)).
        Int64("need", consensus.Decider.TwoThirdsSignersCount()).
        Str("validatorPubKey", recvMsg.SenderPubkey.SerializeToHexStr()).
        Msg("[onViewChange] Received Enough View Change Messages")
    return
}

this part was a no-op, because it never reach quorum. But it wasn't a problem because after that it's checked by Mask.
So to me, there wasn't a problem maybe. Just in the last time view change failed (maybe due to not enough votes). And when I look at the log, I saw the 0 voting power thing in IsQuorumAchieved. But it isn't the cause of view change failure.