return error info if shard does not match #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add error info
return err info
rlan35
reviewed
Jun 17, 2020
node/node.go
Outdated
| @@ -303,8 +303,9 @@ func (node *Node) AddPendingTransaction(newTx *types.Transaction) error { | |||
| node.tryBroadcast(newTx) | |||
| } | |||
| return err | |||
| }else{ | |||
|
jenkins, test this please |
Daniel-VDM
suggested changes
Jun 18, 2020
Daniel-VDM
reviewed
Jun 18, 2020
…nd always return tx hash" the same changes in apiv2
rlan35
approved these changes
Jun 20, 2020
Daniel-VDM
approved these changes
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add error info if shard does not match and make sure the rpc return it