Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and add benchmark for consensus msg check #3211

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

rlan35
Copy link
Contributor

@rlan35 rlan35 commented Jul 10, 2020

  1. Remove unused code and cleanup some outdated todos.
  2. Add some benchmark code for consensus messages checking and signature verification. The benchmark result for doing 1000 times of each are:

Time required to sign 1000 sigs: 0.479827 seconds
Time required to unmarshall 1000 consensus msgs: 0.000662 seconds
Time required to marshal 1000 consensus msgs: 0.000453 seconds
Time required to deserialize 1000 sigs: 0.517965 seconds
Time required to hash 1000 messages: 0.001191 seconds
Time required to verify 1000 sigs: 1.444604 seconds

@JackyWYX
Copy link
Contributor

The code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants