Remove expensive bls key serialization code and use the cached version #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlan35
changed the title
gupadhyaya
reviewed
Jul 15, 2020
| @@ -261,8 +263,10 @@ func (s *PublicBlockChainAPI) GetBlockSigners(ctx context.Context, blockNr rpc.B | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| blsPublicKey := new(bls.PublicKey) | |||
| validator.BLSPublicKey.ToLibBLSPublicKey(blsPublicKey) | |||
| blsPublicKey := new(bls_core.PublicKey) | |||
There was a problem hiding this comment.
these allocations are not necessary right? can you remove it throughout?
There was a problem hiding this comment.
it is needed if you want to inline the error check. It shouldn't have performance difference as anyway a new pointer needs to be allocated. So I will leave as is.
gupadhyaya
approved these changes
Jul 15, 2020
|
This PR reduced block sync time for beacon chain from around 0.5s to around 0.25s per block |
|
CPU usage before this PR: After this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of ToLibBLSPublicKey and always use BytesToBLSPublicKey which is the cached version.
Tested locally.