-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node API Tests & README update (Stage 1 of Node API Overhaul) #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused staking test function * Make config more flexible for specifying BLS keys * Refactor script to functional components for legibility
* Make debug.sh build dynamically for faster iteration * Refactor deploy.sh build trigger * Add go test script to test within docker image
Daniel-VDM
force-pushed
the
pr-rpc-tests
branch
6 times, most recently
from
July 18, 2020 10:55
8e627e4
to
1c2ba58
Compare
Daniel-VDM
force-pushed
the
pr-rpc-tests
branch
2 times, most recently
from
July 18, 2020 11:38
c54aef2
to
04860cc
Compare
Daniel-VDM
changed the title
[WIP] Node API Tests & README update (Stage 1 of Node API Overhaul)
Node API Tests & README update (Stage 1 of Node API Overhaul)
Jul 18, 2020
* Remove slack notification * Parallelize tests
rlan35
approved these changes
Jul 18, 2020
LeoHChen
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 1 of Node API Overhaul
This PR hooks in the Node API tests written here via a
docker run
command. One can simply domake test
to run all the tests that our CI will do.This PR also updates the README to the current state of the project.
Lastly, this PR also changes the Travis yml file to hook in the Node API test & parallelize all the tests. It takes < 10 min to run a PR test now, and can be parallelized on each PR. We can remove the Jenkins test after this PR is merged.
See also.