Add back multi-sig support and fix the multi-sig check for harmony nodes #3337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi-sig, there was a condition to disallow multi-sig signed from multiple accounts. It is to prevent malicious people to double sign and merge with others signature to trigger slashing for other people.
This condition broke testnet since in testnet our nodes contain multiple keys from different accounts. This PR fixes the condition so Harmony nodes can sign blocks with multi-sig without problems.
Basically, the first commit is a revert of a revert, which is already reviewed. The second commit is the fix: eeb8e31
Tested on local net. Will deploy to testnet.