Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosetta] Mempool Endpoint #3339

Merged
merged 11 commits into from
Sep 23, 2020
5 changes: 3 additions & 2 deletions rosetta/rosetta.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ func newHTTPServer(handler http.Handler) *http.Server {

func getRouter(asserter *asserter.Asserter, hmy *hmy.Harmony) http.Handler {
return server.NewRouter(
server.NewNetworkAPIController(services.NewNetworkAPI(hmy), asserter),
server.NewBlockAPIController(services.NewBlockAPI(hmy), asserter),
server.NewAccountAPIController(services.NewAccountAPI(hmy), asserter),
server.NewBlockAPIController(services.NewBlockAPI(hmy), asserter),
server.NewMempoolAPIController(services.NewMempoolAPI(hmy), asserter),
server.NewNetworkAPIController(services.NewNetworkAPI(hmy), asserter),
)
}

Expand Down
85 changes: 85 additions & 0 deletions rosetta/services/mempool.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
package services

import (
"context"

"github.com/coinbase/rosetta-sdk-go/server"
"github.com/coinbase/rosetta-sdk-go/types"
ethCommon "github.com/ethereum/go-ethereum/common"
hmyTypes "github.com/harmony-one/harmony/core/types"
"github.com/harmony-one/harmony/hmy"
"github.com/harmony-one/harmony/rosetta/common"
)

// MempoolAPI implements the server.MempoolAPIServicer interface
type MempoolAPI struct {
hmy *hmy.Harmony
}

// NewMempoolAPI creates a new instance of MempoolAPI
func NewMempoolAPI(hmy *hmy.Harmony) server.MempoolAPIServicer {
return &MempoolAPI{
hmy: hmy,
}
}

// Mempool ...
func (s *MempoolAPI) Mempool(
ctx context.Context, req *types.NetworkRequest,
) (*types.MempoolResponse, *types.Error) {
if err := assertValidNetworkIdentifier(req.NetworkIdentifier, s.hmy.ShardID); err != nil {
return nil, err
}

pool, err := s.hmy.GetPoolTransactions()
if err != nil {
return nil, common.NewError(common.CatchAllError, map[string]interface{}{
"message": "unable to fetch pool transactions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a good idea to also give the err message here.

})
}
txIDs := make([]*types.TransactionIdentifier, pool.Len())
for i, tx := range pool {
txIDs[i] = &types.TransactionIdentifier{
Hash: tx.Hash().String(),
}
}
return &types.MempoolResponse{
TransactionIdentifiers: txIDs,
}, nil
}

// MempoolTransaction ...
func (s *MempoolAPI) MempoolTransaction(
ctx context.Context, req *types.MempoolTransactionRequest,
) (*types.MempoolTransactionResponse, *types.Error) {
if err := assertValidNetworkIdentifier(req.NetworkIdentifier, s.hmy.ShardID); err != nil {
return nil, err
}

hash := ethCommon.HexToHash(req.TransactionIdentifier.Hash)
poolTx := s.hmy.GetPoolTransaction(hash)
if poolTx == nil {
return nil, &common.TransactionNotFoundError
}

var nilAddress ethCommon.Address
estReceipt := &hmyTypes.Receipt{
PostState: []byte{},
Status: hmyTypes.ReceiptStatusSuccessful, // Assume transaction will succeed
CumulativeGasUsed: poolTx.Gas(),
Bloom: [256]byte{},
Logs: []*hmyTypes.Log{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing logs here for collect reward transaction will cause an error, reference:

func getAmountFromCollectRewards(
receipt *hmytypes.Receipt, senderAddress ethcommon.Address,
) (*types.Amount, *types.Error) {
var amount *types.Amount
logs := findLogsWithTopic(receipt, staking.CollectRewardsTopic)
for _, log := range logs {
if log.Address == senderAddress {
amount = &types.Amount{
Value: fmt.Sprintf("%v", big.NewInt(0).SetBytes(log.Data)),
Currency: &common.Currency,
}
break
}
}
if amount == nil {
return nil, common.NewError(common.CatchAllError, map[string]interface{}{
"message": fmt.Sprintf("collect rewards amount not found for %v", senderAddress),
})
}
return amount, nil
}

Can just create some dummy logs with the collect reward topic and have the value at 0.

TxHash: poolTx.Hash(),
ContractAddress: nilAddress, // ContractAddress is only for smart contract creation & can not be determined until transaction is finalized
GasUsed: poolTx.Gas(),
}

respTx, err := formatTransaction(poolTx, estReceipt)
if err != nil {
return nil, err
}

return &types.MempoolTransactionResponse{
Transaction: respTx,
}, nil
}