Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[consensus] enable the consensus module can spin up doSync" #3350

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

JackyWYX
Copy link
Contributor

Reverts #3340. Out of sync is flooding testnet. May research more later.

@JackyWYX JackyWYX requested a review from rlan35 September 17, 2020 05:12
@JackyWYX JackyWYX self-assigned this Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #3350 into main will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   34.31%   34.30%   -0.02%     
==========================================
  Files         209      209              
  Lines       25022    25020       -2     
==========================================
- Hits         8586     8582       -4     
- Misses      15782    15786       +4     
+ Partials      654      652       -2     
Impacted Files Coverage Δ
api/service/syncing/syncing.go 6.26% <0.00%> (-0.03%) ⬇️
consensus/validator.go 0.00% <0.00%> (ø)
core/blockchain.go 8.17% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4089ea0...37c9dfb. Read the comment docs.

@rlan35 rlan35 merged commit 3adab44 into main Sep 17, 2020
@LeoHChen LeoHChen deleted the revert-3340-sync_consensus_fix branch September 27, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants