Rosetta Implementation Cleanup FIX (Stage 3 of Node API Overhaul) #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
* Add GetPreStakingBlockRewards with cache Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Daniel-VDM
force-pushed
the
rosetta-pre-staking-reward-fix
branch
from
c8977d7 to
5ee1e79
Compare
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
LeoHChen
approved these changes
Oct 23, 2020
rlan35
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 3 Cleanup FIX of Node API Overhaul
This is related to #3390
In the clean-up PR, I attempted to fix the pre-staking block 'off-by-one' errors that I got in my testing using the rosetta-cli. However, in further fuzzing-esk testing (different committee sizes, different transactions going off in the pre-staking era, etc...) I found that in some (rare) cases, there would still be an off-by-one error.
I've now changed the pre-staking block reward calculations to call the exact same functions as in
chain.AccumulateRewardsAndCountSigs, even when fetching the block signers. I've tested this fix against said test and it appears to work.