Release Candidate 2023.2.6 (dev -> main) #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid dht prevents to start localnet.
The function `state_object.CodeSize` erroneously returns the validator code size to be 0. This functionality is only used by the EVM, where the size is overridden by the `ValidatorCodeFixEpoch` hard fork to be 0 anyway. However, for nodes currently syncing blocks before the hard fork was effective, this causes an error. A transaction which attempts to mint an NFT to a validator address prior to the hard fork would have failed, because `onERC1155Received` is not implemented by a validator's code. With the erroneous line, the transaction goes through - causing a node with the unpatched binary to reject the block.
* [build] upgrade docker in travis build to latest * add comment to the before_install job --------- Co-authored-by: Gheis Mohammadi <Gheis.Mohammadi@gmail.com>
GheisMohammadi
approved these changes
Aug 3, 2023
MaxMustermann2
approved these changes
Aug 3, 2023
* [build] upgrade docker in travis using addons * [build] upgrade docker in travis with debug command * [build] retrying addons * [build] debug log * [build] clean debug log
diego1q2w
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol changes :
#4475 - statedb: return correct validator code size, fix sync issue
Ops/Build changes
#4472 - Invalid dht prevents to start localnet
#4478 #4480 #4481 - upgrade docker in travis build to latest