Release Candidate 2023.2.7 (dev -> main) #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix consensus catchup issue
disable go test verbose flag
update deprecated go-libp2p packages
ONECasey
approved these changes
Aug 8, 2023
adsorptionenthalpy
approved these changes
Aug 10, 2023
* add error desc in validateNewBlock to help to identify validation issues * let stream sync downloader continues loop even if error occured * pass consensus to stream sync through downloader * add last mile functions to stream sync * add if to check invalid block revert * add last mile stage to stream sync * goimports * improve stream sync downloader loop to block redundant calls * move startSyncing out of the shortrange loop * goimports * fix sync loop go routine * remove extra log * add debug mode to stream sync help debugging syncing issues * fix stream sync loop channels * add streamFailed function to short range helper to avoid removing of the healthy streams * remove execution of stage bodies, stage lastmile, stage short range and stage state for epoch chain * refactor stage epoch * add debug logs * goimports * add a few debug log to stage short range * doSync returns estimated height as well * only switch to short range if the current block number is very close to the chain current height * stream sync gets UseMemDb from config file * goimports * only flag failed streams rather than removing them in stream sync * if stage blocks progress behind current head, remove block cache * add rollback to short range * refactor stage last mile blocks, add roll back to this stage * improve addConsensusLastMile * goimports * fix log spell error * improve revert function, no need to revert if hashes are empty * fix switch to short range by removing extra condition * add donC chan size * refactor downloader loop mechanism * use atomic flag rather than done channel in downloader loop * no need for fail stream in epoch sync * ignore context timeout * add mux lock to get access to last mile blocks * remove atomic flag for downloader loop * a few improvements on staged sync, check addedBn before switch to short range * goimports * fix consensus catchup issue * fix panic issue from runnig sync loop while stream sync is runing * goimports * add two more logs to staged sync * remove extra debug logs, add more file logs for stream sync * add comment for DebugMode * improve the byte comparison for getBlockFromLastMileBlocksByParentHash function
* Keep rotation meta in memory. * Proper name for struct. * Clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol changes :
#4467 - Improve staged stream sync, fix the devnet node stuck issue (still waiting to be merged)
#4474 - fix consensus catchup issue
#4483 - update deprecated go-libp2p packages
#4459 - Keep rotation meta in memory
Ops/Build changes:
#4482 - disable go test verbose flag
#4486 - Enable Mergify