Fixed data race. #4559
Merged
Fixed data race. #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
| } | ||
|
|
||
| consensus.mutex.Lock() | ||
| consensus.getLogger().Info().Msg("[preCommitAndPropose] Start consensus timer") | ||
| consensus.consensusTimeout[timeoutConsensus].Start() | ||
|
|
||
| // Send signal to Node to propose the new block for consensus | ||
| consensus.getLogger().Info().Msg("[preCommitAndPropose] sending block proposal signal") |
There was a problem hiding this comment.
No, we obtained lock above on line 584
There was a problem hiding this comment.
GetLogger() has lock inside, so it will be deadlock.
There was a problem hiding this comment.
GetLogger is a public function, it should be improved to not have such a constraints. We can't make a function public and ask users to not use it in a certain conditions, right?
| consensus.getLogger().Info().Msg("[preCommitAndPropose] Start consensus timer") | ||
| consensus.consensusTimeout[timeoutConsensus].Start() | ||
|
|
||
| // Send signal to Node to propose the new block for consensus | ||
| consensus.getLogger().Info().Msg("[preCommitAndPropose] sending block proposal signal") | ||
|
|
||
| consensus.mutex.Unlock() |
There was a problem hiding this comment.
No, we release lock exactly here.
There was a problem hiding this comment.
to excludes line consensus.ReadySignal(AsyncProposal) ? any reason for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain fixes for 4 data races i've found during testing devnet with enabled race detector. This PR arrives after we first time faced
block existserror, which looks like the concurrency issue.#4558
#4557
#4556
#4555