Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ShardIDFromKey #4566

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix for ShardIDFromKey #4566

wants to merge 1 commit into from

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Nov 17, 2023

@sophoah
Copy link
Contributor

sophoah commented Nov 22, 2023

@Frozen i think that one is good. Can you add two tests dealing with a network that has HIP30 epoch defined as TBD, and another one set with a fixed number. First one should use the default / genesis sharding config while the other one should use the sharding config of HIP30.

Things to note, at the end what we want is to know the latest sharding configuration (4 shard vs 2 shards) when we start the node from height 0, be it with HIP30 or with future HIP, so maybe we could define a function that does just that.

@diego1q2w @GheisMohammadi feel free to chime in any other ideas.

@Frozen Frozen self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants