Fix for crosslink snap db. #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here the reasoning for that PR : Crosslink before an epoch or blocks that have been pruned using snapDB will set exist, err := node.Blockchain().ReadCrossLink(pending.ShardID(), pending.BlockNum())This is what happened last time in mainnet when we tried to add a crosslink for a block/epoch we didn't have. Our solution back then was to remove those pending crosslink because we knew they were already processed. in theory, crosslink already added on s0 chain are all continuous, so we can create a function that check the lastcrosslink (added on chain) and delete the pending crosslink when the block number in the shard to be processed is older. |
sophoah
approved these changes
May 23, 2024
GheisMohammadi
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for crosslink snap db.