Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boot node instability issue, refactor p2p host configurations and add new features to p2p #4676

Merged
merged 1 commit into from
May 24, 2024

Conversation

GheisMohammadi
Copy link
Contributor

Issue

After upgrading the boot nodes to the latest version of the main branch, which includes several changes compared to the previous boot node code, the boot node service process began restarting repeatedly. This was accompanied by numerous error messages related to the QUIC protocol, noise, sessions, muxers, and various other lower layer P2P issues.

This PR addresses these issues by making the following changes:

  • Removes QUIC, an unnecessary feature, and switches to TCP transport.
  • Makes TLS/Noise, relays, and NAT optional features that can be disabled via configuration.
  • Adds a dial timeout for the connection manager.
  • Allows the use of the MPlex muxer in addition to Yamux.

Additionally, this PR introduces several new configurations and flags, detailed below:
NoTransportSecurity: to disable p2p security (tls and noise)
NAT: enable p2p NAT. NAT Manager takes care of setting NAT port mappings, and discovering external addresses
UserAgent: custom user agent; explicitly set the user-agent, so we can differentiate from other Go libp2p users
DialTimeout: p2p dial timeout
MuxerType: P2P multiplexer type (default:Mplex, 0:Mplex, 1:Yamux)
NoRelay: No relay services, direct connections between peers only

@GheisMohammadi GheisMohammadi self-assigned this May 23, 2024
@GheisMohammadi GheisMohammadi requested a review from mur-me May 23, 2024 14:34
@sophoah
Copy link
Contributor

sophoah commented May 24, 2024

Thanks @GheisMohammadi

leaving here a link to the an explanation of the new p2p configuration : #4674 (comment)

@sophoah sophoah merged commit 3d29596 into dev May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants