-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/keep tests in separate repo for upgrade to 1.22 #4736
feat/keep tests in separate repo for upgrade to 1.22 #4736
Conversation
15218db
to
79a245f
Compare
@Frozen can you explain why we need core/genesis/go19.go, core/genesis/go20.go and why there isn't something for go 1.22 ? |
@Frozen should we also update : api/service/legacysync/downloader/Proto.Dockerfile ? the dockerfile was added in #4427 @mur-me there is a few instances of 1.19, please help update https://github.com/search?q=repo%3Aharmony-one%2Fharmony+1.19&type=code |
75f5b7d
to
1e2179d
Compare
1e2179d
to
821698d
Compare
Changed to 1.22 |
Proto.Dockerfile already updated |
see detail test #4722 (comment) |
Issue
This PR has all the work from the #4722 PR, except commit that is moving tests to the repo
Test
Unit Test Coverage
Before:
After:
Test/Run Logs
Operational Checklist
Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)
YES|NO
Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.
Describe how the plan was tested.
How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?
What are the planned flag epoch numbers and their ETAs on Pangaea?
What are the planned flag epoch numbers and their ETAs on mainnet?
Note that this must be enough to cover baking period on Pangaea.
What should node operators know about this planned change?
Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)
YES|NO
Does the existing
node.sh
continue to work with this change?What should node operators know about this change?
Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?
TODO