Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock free consensus methods #4739

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Lock free consensus methods #4739

merged 3 commits into from
Sep 3, 2024

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Aug 19, 2024 •
edited
Loading

  1. Moved PostConsensusProcessing from node to consensus, because method uses consensus methods, but not node.
  2. Consensus uses validateShardBoundMessage indirectly, but validateShardBoundMessage uses consensus internally which causes deadlock. Changed method called by validateShardBoundMessage to be lock free.
  3. Synchronious calls to SendMessageToGroups because it uses validateShardBoundMessage internally, but now it save to use without deadlocks.

@Frozen Frozen self-assigned this Aug 19, 2024
@sophoah sophoah changed the title Lock free consensus methods. Lock free consensus methods Aug 28, 2024
@Frozen Frozen merged commit 4718a1c into dev Sep 3, 2024
4 checks passed
@Frozen Frozen deleted the feature/lock-free-message-valdation branch September 3, 2024 00:02
@sophoah sophoah mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophoah sophoah sophoah approved these changes

@mur-me mur-me mur-me approved these changes

@GheisMohammadi GheisMohammadi Awaiting requested review from GheisMohammadi

Assignees

@Frozen Frozen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frozen @mur-me @sophoah