Fix for crosslink processing. #4751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
| if len(pendingCLs) >= maxPendingCrossLinkSize { | ||
| if err == nil && len(pendingCLs) >= maxPendingCrossLinkSize { |
There was a problem hiding this comment.
In the original code (see here), we also didn't handle the case where err != nil. @Frozen made an attempt to address this in PR #4673 (see here), which was included in the v2024.2.0 release. However, we hadn't tested this with a fresh network using external validators until now.
@Frozen @GheisMohammadi, the error we're encountering is level DB: not found. Since this error only arises when the key in LevelDB doesn't exist, should we consider updating our code to simply continue execution in this case, and return if any other error is encountered?
There was a problem hiding this comment.
@Frozen, what are your thoughts on PR #4754? It addresses the same issue but introduces a few additional improvements:
- Added a mutex to prevent potential concurrency issues.
- Similar to your approach, it ensures that if
err != nil, we don't block; however, in this case, we at least log the error for better visibility.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for crosslink processing.