Not Checking Pending Crosslinks for First ten Epoch #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GheisMohammadi
force-pushed
the
fix/delete_pending_crosslinks
branch
from
2734958 to
85eb1b7
Compare
sophoah
reviewed
Sep 20, 2024
sophoah
approved these changes
Sep 24, 2024
|
@Frozen please review / approve. Thanks |
Frozen
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current code attempts to delete pending crosslinks that are older than 10 epochs. However, if the pending crosslinks were not added to the database within the first 10 epochs, this can lead to an
leveldb: not found. This PR resolves the issue by adding a condition to skip checking pending crosslinks during the first 10 epochs, ensuring we avoid unnecessary database lookups and potential errors.