Fixed off-by-one error when processing matches - the simplified API o…

…bject only stores matches starting at the question AFTER the current
harmonydata · Jul 5, 2023 · c3e552e · c3e552e
1 parent 129bd4b
commit c3e552e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/components/App.js b/src/components/App.js
@@ -101,9 +101,9 @@ function App() {
       return instrument.questions.map(q=>{
         return q.matches.reduce(function (a, e, i) {
           if (Math.abs(e) >= (resultsOptions.threshold/100) && 
-              (resultsOptions.intraInstrument || (i+q.question_index) > instrument.maxqidx )) {
-            var mq = getQuestion(i+q.question_index);
-            var mi = getInstrument(i+q.question_index);
+              (resultsOptions.intraInstrument || (i + 1 + q.question_index) > instrument.maxqidx )) {
+            var mq = getQuestion(i + 1 + q.question_index);
+            var mi = getInstrument(i + 1 +q.question_index);
             a.push(
               {
                 instrument1: instrument.name,

diff --git a/src/components/Results.js b/src/components/Results.js
@@ -31,8 +31,8 @@ export default function Results({ apiData, setApiData, setResultsOptions, result
       return (apiData.map(instrument => {
         return instrument.questions.map(q => {
           return q.matches.reduce(function (a, e, i) {
-            if (Math.abs(e) >= (resultsOptions.threshold / 100) && (resultsOptions.intraInstrument || (i + q.question_index) > instrument.maxqidx))
-              a.push({ qi: q.question_index, mqi: i + q.question_index, match: e });
+            if (Math.abs(e) >= (resultsOptions.threshold / 100) && (resultsOptions.intraInstrument || (i + 1 + q.question_index) > instrument.maxqidx))
+              a.push({ qi: q.question_index, mqi: i + 1 + q.question_index, match: e });
             return a;
           }, [])
         }).flat();