Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GuildChannelsManager.keys() #300

Merged
merged 5 commits into from
Jan 23, 2022
Merged

Fix GuildChannelsManager.keys() #300

merged 5 commits into from
Jan 23, 2022

Conversation

ZiomaleQ
Copy link
Contributor

About

This pr fixes issue #293

Adding override for keys method

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

DjDeveloperr
DjDeveloperr requested changes Jan 23, 2022
View reviewed changes
src/managers/guildChannels.ts Outdated Show resolved Hide resolved
@DjDeveloperr DjDeveloperr added the bugfix 🔨 This is a fix for a bug. label Jan 23, 2022
@DjDeveloperr DjDeveloperr linked an issue Jan 23, 2022 that may be closed by this pull request
[Bug] guild.channels.keys() should return keys only from its own guild #293
Closed
@DjDeveloperr DjDeveloperr merged commit 84f73af into harmonyland:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
bugfix 🔨 This is a fix for a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] guild.channels.keys() should return keys only from its own guild
2 participants
@ZiomaleQ @DjDeveloperr