Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'raw' emojis #347

Merged
merged 5 commits into from
May 17, 2023
Merged

Support 'raw' emojis #347

merged 5 commits into from
May 17, 2023

Conversation

ZiomaleQ
Copy link
Contributor

About

This pr adds option to pass emoji with enclosing <>, both to <TextChannel>.addReaction and <TextChannel>.removeReaction. Earlier harmony didn't said explicitly that it expects emoji strings without <>.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@Helloyunho
Copy link
Member

now that I think about this, I wonder is there any function that I forgot to do this conversion...

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho merged commit daca400 into harmonyland:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants