feat(jsonnet): support setting extVars #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extVars` are a concept of Jsonnet that allow to inject data into the compiler from the command line. At Grafana, we have a build-image whose tag must be consistent across all CI systems, so we use such an extVar for this. To be able to adopt drone-cli (were using plain `jsonnet` before) we need this functionality exposed :D
tboerger
approved these changes
Nov 16, 2019
|
Hey, could this possibly be merged? Would be cool if we could do the switch to |
|
I would be able to merge that, but I would like to get the opinion of brad |
appleboy
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extVarsis a concept of Jsonnet that allow to inject data into the compilerfrom the command line.
At Grafana, we have a build-image whose tag must be consistent across all CI
systems, so we use such an extVar for this.
To be able to adopt drone-cli (were using plain
jsonnetbefore) we need thisfunctionality exposed :D