Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fix multi-docs/lists in starlark #200

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Sep 7, 2021

➜  drone-cli git:(starlark_multi_fix) ✗ release/linux/amd64/drone starlark --source=multi.star   --stdout=true
---
{"kind": "pipeline", "name": "build-amd64", "steps": [{"name": "build", "image": "alpine", "commands": ["echo hello world"]}]}
---
{"kind": "pipeline", "name": "build-arm64", "steps": [{"name": "build", "image": "alpine", "commands": ["echo hello world"]}]}
➜  drone-cli git:(starlark_multi_fix) ✗ release/linux/amd64/drone starlark --source=multi.star   --stdout=true  --format
---
kind: pipeline
name: build-amd64
steps:
- commands:
  - echo hello world
  image: alpine
  name: build
---
kind: pipeline
name: build-arm64
steps:
- commands:
  - echo hello world
  image: alpine
  name: build
➜  drone-cli git:(starlark_multi_fix) ✗ release/linux/amd64/drone starlark --source=bla.star   --stdout=true
---
{"kind": "pipeline", "name": "build", "steps": [{"name": "build", "image": "alpine", "commands": ["echo hello world"]}]}%
➜  drone-cli git:(starlark_multi_fix) ✗ release/linux/amd64/drone starlark --source=bla.star   --stdout=true --format
kind: pipeline
name: build
steps:
- commands:
  - echo hello world
  image: alpine
  name: build
➜  drone-cli git:(starlark_multi_fix) ✗

@eoinmcafee00 eoinmcafee00 self-requested a review September 7, 2021 14:22
@mwalbeck
Copy link

mwalbeck commented Sep 7, 2021

Hi! Thanks for the quick response on this. I just gave it a quick test and everything works as expected. It gave the exact same output as v1.3.0. I messed up my test somewhere, but I get a valid drone.yml will all the steps!

Cheers!

@eoinmcafee00 eoinmcafee00 merged commit 1a4c6c1 into harness:master Sep 8, 2021
@tphoney tphoney added the bug label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants