feat: ESLint and Prettier

[NickyMeuleman]

wip

[NickyMeuleman]

Please review those @typescript rules that are disabled.

Having trouble with parserOptions.project path. When I enter ./tsconfig.json the eslint in the project works fine, but the eslint extension in the editor freaks out, resulting in an error at the top of every file.
When I enter ./packages/frontend/tsconfig.json the editor extension pick it up no problem, but the eslint in the project (called through CLI) throws not found errors

[NickyMeuleman]

Using this PR as a place to write down issues I encounter while working this.

Lots of import/no-unresolved issues (100+)
think it is related to:
import-js/eslint-plugin-import#720

future me: It wasn't, see below

Will try to update package, hope it doesn't break airbnb ruleset.
edit: added plugin:import/typescript
Seems to work, now the errors changed to Cannot find module 'typescript-eslint-parser' (undefined:undefined)eslint(import/named)
edit2: having trouble since typescript-eslint-parser is deprecated.
trying import-js/eslint-plugin-import#1283

[NickyMeuleman]

imports still not working, trying to work in a .eslintrc.js file is hard. I miss my intellisense :p

Will wait until that PR gets fleshed out and merged. Then I'll try again.

Laptop gets supertoasty while reloading the project. 100% CPU/RAM/HDD usage does that, I guess.
Sleep now, it's 1 am

[NickyMeuleman]

Well I tried again before it was merged anyway.
Imports now work 🎉
Turns out I made a stupid error and also included their plugin configuration in extends, whoops!

Making many commits here so I can use this to keep track of what's done.
Don't worry, I'll squash and merge when I'm done.

[NickyMeuleman]

Added an optional alt prop to the TalkCard for the images alt props.
If not provided it falls back to the heading prop.

[NickyMeuleman]

Done with frontend!
It's wonderful, WONDERFUL

Tomorrow is backend and then extracting shared stuff to the project root. Finally restore the lint-staged.

NB: only files affected by the tsconfig in frontend are affected right now, as defined by the project key in .eslintrc. This is needed for type specific linting 🎉🚀

[NickyMeuleman]

Backend was easy.

Ran into trouble when trying to add ESLint to the entire workspace (to later remove duplicates from both frontend and backend)

Seems like our .js files are not being linted

typescript-eslint/typescript-eslint#109

[NickyMeuleman]

Tried to centralize the eslint dependencies.

Now imports are broken again (eventhough the rules are still local)
Running ESLint results in lots of Resolve error: typescript with invalid interface loaded as resolver

[NickyMeuleman]

Having a base config in root and others in packages could be a problem
eslint/eslint#820

reading: https://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy

The way I'm seeing it working right now is that rules I placed in root (because both frontend and backend use them) are simply not being picked up.

[NickyMeuleman]

Well, monorepos confuse me.

Did further centralization of rules (according to eslint docs)
The Typescript resolver plugin was not installed in root somehow.
That coupled with a settings key solved import problems.

no-unused-vars started firing in backend when I centralized that rule, weird, doesn't @typescript-eslint/no-unused-vars replace it?

Running yarn lint:ws still doesn't work. It hangs a while, then outputs this error:

Deleted every node_modules folder and ran yarn in root. No dice, didn't help.

All in all, ready for review. This monorepo configuration is mindbending to me so I might be making some obvious error.

[pantharshit00]

Please use lerna for monorepo tasks.

Otherwise great work 🙌

[NickyMeuleman]

Ok.
Going to merge this now.

Only linting inside packages/frontend or packages/backend

Linting .js files acted weird in testing. Not being picked up by the CLI tool. Because the --ext option is passed for .ts and .tsx. It refused to run when you pass .js to that --ext option.
Also see typescript-eslint/typescript-eslint#109