forked from vmware/pyvmomi
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes KeyError signatures to use `format` instead of `%` partial: vmware#55
- Loading branch information
Showing
1 changed file
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c84a6a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it - though you could use singlequotes for these format strings, that's a tiny nit and not sure how that fits in to the style guide for this project overall.
c84a6a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I would just enforce
pep8
style, but this project has its own unique style right now. I'm open to suggestions for establishing a style.Edit:
NOTE - I don't want style based changes in this release.
c84a6a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pep8 is the best way to go (least surprise) and we can take care of that all in one go when you are ready.