Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support catching all errors, #220 #710

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

harttle
Copy link
Owner

@harttle harttle commented Jun 17, 2024

Catching multiple errors before quit when catchAllErrors option is set. However there's some caveats.

  1. It only catches all LiquidError, other errors like code bug are not catched in this way. So you'll need to check err.name === 'LiquidErrors' before using.
  2. Top level tokennization errors are not catched, as there's no such concept of Token during this step. e.g. partial tag {% foo
  3. Render errors should be catched perfectly. e.g. undefined variables, nonexist filters/tags, as well as errors thrown in filters/tags.

@harttle harttle merged commit 3b5627b into master Jun 17, 2024
11 checks passed
@harttle harttle deleted the feat-render-errors branch June 17, 2024 14:49
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
# [10.14.0](v10.13.1...v10.14.0) (2024-06-17)

### Bug Fixes

* use drop `valueOf` when evaluated as condition ([#705](#705)) ([a7da93f](a7da93f))

### Features

* support catching all errors, [#220](#220) ([#710](#710)) ([3b5627b](3b5627b))
Copy link

🎉 This PR is included in version 10.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant