Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATGU-507: Course Setup Checklist Updates #24

Merged
merged 7 commits into from
Aug 15, 2016
Merged

ATGU-507: Course Setup Checklist Updates #24

merged 7 commits into from
Aug 15, 2016

Conversation

arthurian
Copy link
Contributor

@arthurian arthurian commented Aug 10, 2016

This PR implements some changes to the Course Setup Checklist and Import Content page for FAS (requested by Daniel Jamous).

Acceptance testing completed by Daniel Jamous on Thurs. Aug. 11th in canvas test environment.

@cmurtaugh This has been tested and code reviewed. Unless there are any major concerns, I think this should be OK to merge.


Course Setup Checklist:

  • Import Content: Remove sentence “If you would like to incorporate content from a previous iSite, please contact the Academic Technology Group at atg@fas.harvard.edu
  • Add TFs to the Course: The button should take you to the Manage Course tool, since the functionality of the Manage People tool has been merged into that and it is not possible (currently) to link directly to the Manage People tool within that.
  • Select Navigation Links: Modify the link so that it takes you straight to the Navigation tab, as it currently does not.
  • Choose a Course Home Page: In the text of that one it says at the end “The default is the Course Activity Stream”. This should read “The default is the Syllabus Page with course description”
  • Add Files to the Course: Remove the text that says “We’ll show you how”. When you click the button to go to the file upload page, nothing actually happens so removing this text will hopefully avoid any confusion.

Import Content:

  • Change the text that appears on the page to say “if you would like to incorporate content from a previous iSite click HERE” where HERE is a link to the Manage Course tool.

@arthurian arthurian changed the title WIP - Updates to FAS Course Setup Checklist Course Setup Checklist Updates Aug 10, 2016
@arthurian arthurian changed the title Course Setup Checklist Updates ATGU-507: Course Setup Checklist Updates Aug 10, 2016
@elliottyates elliottyates self-assigned this Aug 11, 2016
@eparker71
Copy link
Contributor

👍 Looks great to me. @elliottyates can you also give this a pass over?

@@ -20,7 +25,9 @@
function modify_import_content_page($) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this shouldn't live in checklist.js but rather be a separate file, no? I guess it was like this before, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it probably should live in a separate file since that code isn't really part of the checklist module. Good suggestion.

@elliottyates
Copy link
Contributor

👍

@arthurian
Copy link
Contributor Author

@cmurtaugh Any objections to merging and releasing this as-is?

@cmurtaugh
Copy link
Contributor

👍

@arthurian arthurian merged commit 28ded4e into harvard-canvas-branding:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants