-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATGU-507: Course Setup Checklist Updates #24
Conversation
…he COURSE_WIZARD env variable.
Fix console error
👍 Looks great to me. @elliottyates can you also give this a pass over? |
@@ -20,7 +25,9 @@ | |||
function modify_import_content_page($) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this shouldn't live in checklist.js
but rather be a separate file, no? I guess it was like this before, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it probably should live in a separate file since that code isn't really part of the checklist module. Good suggestion.
👍 |
…sibility per @Vittorio2015 and @elliottyates suggestion.
@cmurtaugh Any objections to merging and releasing this as-is? |
👍 |
This PR implements some changes to the Course Setup Checklist and Import Content page for FAS (requested by Daniel Jamous).
Acceptance testing completed by Daniel Jamous on Thurs. Aug. 11th in canvas test environment.
@cmurtaugh This has been tested and code reviewed. Unless there are any major concerns, I think this should be OK to merge.
Course Setup Checklist:
Import Content: