Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-data-engineering #254

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Sara-Khosravi
Copy link
Contributor

@Sara-Khosravi Sara-Khosravi commented Jun 8, 2024

Improved the introduction section of the data engineering chapter by clarifying concepts and adding new examples.

Before submitting your Pull Request, please ensure that you have carefully reviewed and completed all items on this checklist.

  1. Content

    • The chapter content is complete and covers the topic in detail.
    • All technical terms are well-defined and explained.
    • Any code snippets or algorithms are well-documented and tested.
    • The chapter follows a logical flow and structure.
  2. References & Citations

    • All references are correctly listed at the end of the chapter.
    • In-text citations are used appropriately and match the references.
    • All figures, tables, and images have proper sources and are cited correctly.
  3. Quarto Website Rendering

    • The chapter has been locally built and tested using Quarto.
    • All images, figures, and tables render properly without any glitches.
    • All images have a source or they are properly linked to external sites.
    • Any interactive elements or widgets work as intended.
    • The chapter's formatting is consistent with the rest of the book.
  4. Grammar & Style

    • The chapter has been proofread for grammar and spelling errors.
    • The writing style is consistent with the rest of the book.
    • Any jargon is clearly explained or avoided where possible.
  5. Collaboration

    • All group members have reviewed and approved the chapter.
    • Any feedback from previous reviews or discussions has been addressed.
  6. Miscellaneous

    • All external links (if any) are working and lead to the intended destinations.
    • If datasets or external resources are used, they are properly credited and linked.
    • Any necessary permissions for reused content have been obtained.
  7. Final Steps

    • The chapter is pushed to the correct branch on the repository.
    • The Pull Request is made with a clear title and description.
    • The Pull Request includes any necessary labels or tags.
    • The Pull Request mentions any stakeholders or reviewers who should take a look.

Improved the introduction section of the data engineering chapter by clarifying concepts and adding new examples.
@Sara-Khosravi
Copy link
Contributor Author

@profvjreddi

Hi Vijay,

I hope all is well. I will be more focused on this after delivering one of my projects. Please let me know if I need to read any specific sources or materials.

I appreciate any help you can provide.

Warm regards,
Sara

@profvjreddi
Copy link
Contributor

Thanks, @Sara-Khosravi, for these edits. Much appreciated. I think you making your way through the chapters section by section would be great! My biggest thing is to see you learning new things and, of course, in that process, helping others learn by improving the material, be it for readability or clarity. So just keep plowing ahead. And if your mind things that should be newly added then feel free to file issues as I do make my way through them whenever i find some time.

@profvjreddi profvjreddi merged commit feccf8f into harvard-edge:dev Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants