fix unit test failed

Signed-off-by: andy.lee <andy.lee@suse.com>
harvester · Aug 15, 2024 · 0846983 · 0846983
1 parent 9c9a821
commit 0846983
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/pkg/harvester/edit/harvesterhci.io.schedulevmbackup.vue b/pkg/harvester/edit/harvesterhci.io.schedulevmbackup.vue
@@ -6,7 +6,6 @@ import CruResource from '@shell/components/CruResource';
 import Tabbed from '@shell/components/Tabbed';
 import Tab from '@shell/components/Tabbed/Tab';
 import MessageLink from '@shell/components/MessageLink';
-import Checkbox from '@components/Form/Checkbox/Checkbox';
 import LabeledSelect from '@shell/components/form/LabeledSelect';
 import CreateEditView from '@shell/mixins/create-edit-view';
 import { isCronValid } from '@shell/utils/validators/cron-schedule';
@@ -20,7 +19,6 @@ import { _EDIT, _CREATE } from '@shell/config/query-params';
 export default {
   name:       'CreateVMSchedule',
   components: {
-    Checkbox,
     CruResource,
     Tabbed,
     Tab,

diff --git a/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/container.vue b/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/container.vue
@@ -145,7 +145,7 @@ export default {
       </div>
     </div>
     <Banner
-      v-if="value?.volumeBackups?.error?.message"
+      v-if="value.volumeBackups && value.volumeBackups.error && value.volumeBackups.error.message"
       color="error"
       class="mb-20"
       :label="value.volumeBackups.error.message"

diff --git a/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/existing.vue b/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/existing.vue
@@ -310,7 +310,7 @@ export default {
       </div>
     </div>
     <Banner
-      v-if="value?.volumeBackups?.error?.message"
+      v-if="value.volumeBackups && value.volumeBackups.error && value.volumeBackups.error.message"
       color="error"
       class="mb-20"
       :label="value.volumeBackups.error.message"

diff --git a/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/vmImage.vue b/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/vmImage.vue
@@ -292,7 +292,7 @@ export default {
       </div>
     </div>
     <Banner
-      v-if="value?.volumeBackups?.error?.message"
+      v-if="value.volumeBackups && value.volumeBackups.error && value.volumeBackups.error.message"
       color="error"
       class="mb-20"
       :label="value.volumeBackups.error.message"

diff --git a/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/volume.vue b/pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineVolume/type/volume.vue
@@ -237,7 +237,7 @@ export default {
       </div>
     </div>
     <Banner
-      v-if="value?.volumeBackups?.error?.message"
+      v-if="value.volumeBackups && value.volumeBackups.error && value.volumeBackups.error.message"
       color="error"
       class="mb-20"
       :label="value.volumeBackups.error.message"

diff --git a/pkg/harvester/list/harvesterhci.io.vmsnapshot.vue b/pkg/harvester/list/harvesterhci.io.vmsnapshot.vue
@@ -67,19 +67,22 @@ export default {
           labelKey:  'tableHeaders.targetVm',
           value:     'attachVM',
           align:     'left',
+          sort:      'attachVM',
           formatter: 'AttachVMWithName'
         },
         {
           name:      'backupCreatedFrom',
           labelKey:  'harvester.tableHeaders.vmSchedule',
           value:     'sourceSchedule',
+          sort:      'sourceSchedule',
           formatter: 'BackupCreatedFrom',
         },
         {
           name:      'readyToUse',
           labelKey:  'tableHeaders.readyToUse',
           value:     'status.readyToUse',
           align:     'center',
+          sort:      'status.readyToUse',
           formatter: 'Checked',
         },
         AGE