Add bower.json and the compiled files to the repo. #2044
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908, #1980, #1845, #1811, #1698, #1656, #1641, #1556, #1509, #1472, #1333.
Also prevents weird edge cases caused by non-standard and non-expected behaviors like in taptapship/wiredep#94.
I am curious as to why it's unacceptable for Chosen to put the built assets in the repo like thousands others have? Or maybe like some others have: why not maintain a separate for-bower-only repo (I see this one as more troublesome, but I have seen it a lot--this would cut down on people accidentally editing the compiled source. It would also help to call the output directory
dist
or something more commonly associated with a compiled output).It sounds to me that you're just choosing (pun intended) to be difficult. :-P I know "just cuz everyone is doing it" isn't a good reason, but it's pretty well accepted as best practices by the community. Even the hooks that Bower did relatively recently add specifically states
Even if Bower did have a legit post install (the reason you keep saying you won't support Bower), you expect people just to use Bower to also have
node
,npm
,grunt
, andruby
installed to build your project in a post install script in Bower?? That's what's insane.Seriously though--I'm not trying to be a jerk (it's just natural)--but please stop blaming Bower as to why you won't throw a bone to the dev community and implementors of your plugin and please really support Bower.