Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1562 now the behavior is the same as the proto version #2268

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

laantorchaweb
Copy link
Contributor

fixed #1562 this class was being added on the prototype version but not in the jquery one. Now is working as expected.

@pfiller
Copy link
Contributor

pfiller commented Mar 26, 2015

Thanks @laantorchaweb. I just looked through the code a bit and I think that we should actually remove the line from the Prototype version as it's no longer necessary. The only thing that's using the class is winnow_results_highlight and it's called only after winnow_results adds the class name.

Going to open a quick PR to do removal.

@pfiller pfiller closed this Mar 26, 2015
This was referenced Mar 26, 2015
@pfiller pfiller reopened this Mar 26, 2015
@pfiller
Copy link
Contributor

pfiller commented Mar 26, 2015

I'm wrong. It is needed... just saw #1562.

Going to merge this!

pfiller added a commit that referenced this pull request Mar 26, 2015
Ensure result-selected is applied immediately when selecting an element
@pfiller pfiller merged commit cca83d1 into harvesthq:master Mar 26, 2015
@pfiller
Copy link
Contributor

pfiller commented Mar 26, 2015

Thanks again, @laantorchaweb!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clicking on an option it disappear
2 participants