Update dev dependencies to use uptodate packages #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjschuck
requested changes
Jul 31, 2017
| @@ -7,7 +7,7 @@ | |||
| <link rel="stylesheet" href="docsupport/prism.css"> | |||
| <link rel="stylesheet" href="chosen.css"> | |||
|
|
|||
| <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self' https://ajax.googleapis.com; style-src 'self'; img-src 'self' data:"> | |||
| <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self' https://ajax.googleapis.com; style-src 'self'; img-src 'self' data:"> | |||
There was a problem hiding this comment.
Is this right? Looking around, it seems like most "Content-Security-Policy" examples use the single-quote-inside-double-quote thing.
There was a problem hiding this comment.
well, escaping is not required, but it is allowed (this is something happening at the HTML level, so the final value has single quotes after parsing).
Escaping the single quote is the result of running dom_munger as part of the prep-release task (the fact that it was not escaped yet is because this change was reverted manually when doing the 1.7.0 release)
There was a problem hiding this comment.
It's weird, but it seems to work, so okay ¯\_(ツ)_/¯
tjschuck
approved these changes
Aug 1, 2017
koenpunt
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dependencies used in the build system were totally outdated (and may not work well on recent versions of node). This updates them.