Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forgotten usage of css clip. #2943

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Conversation

adunkman
Copy link
Contributor

@harvesthq/chosen-developers to fix #2942 originally reported by @taichunmin, a follow-up to #2939 which fixed #2816.

I missed a usage of clip — when the search input is hidden due to search being disabled in options or having fewer than disable_search_threshold items.

This usage of clip was similar to the others — to hide the search input but allow it to still receive keyboard events. We can use the same approach as #2939 — simply make the search input transparent instead.

@taichunmin
Copy link

LGTM

@westonganger
Copy link

westonganger commented Jan 26, 2018

This causes problems with IE11 (I read somewhere pointer-events has issues in IE11). That being said its still better than the previous implementation.

After selecting an item the search input cursor line can still be seen overtop the select.

Anyone know how I could fix this?

@0nehand
Copy link

0nehand commented Feb 6, 2018

I have the same issue as @westonganger above although I see the problem in Chrome and Firefox too. After 1.8.3 was pushed, my selects no longer show what's actually selected. Instead, the search input covers it up. You can see it here: http://alxlit.name/bootstrap-chosen/

Any word on a fix?

@taichunmin
Copy link

@0nehand This is because bootstrap-chosen is outdated for 3 years. There are a lot of difference between chosen and bootstrap-chosen.

@0nehand
Copy link

0nehand commented Feb 7, 2018

@taichunmin Ok thanks. I see there was an issue opened there and a workaround mentioned:
alxlit/bootstrap-chosen#80

@adunkman
Copy link
Contributor Author

adunkman commented Apr 9, 2018

There’s a fix for IE11’s visible carat in this PR. I anticipate that PR will be included in the next release of Chosen, but that issue is unrelated to this PR, so it shouldn’t hold this up.

This causes problems with IE11 (I read somewhere pointer-events has issues in IE11). That being said its still better than the previous implementation.

If you are able to demonstrate a problem, please do so! I don’t see any reproducible issues in IE11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up: Remove clip CSS property Remove CSS clip property
5 participants