Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not apply empty style attribute #2950

Merged
merged 1 commit into from
Apr 11, 2018
Merged

do not apply empty style attribute #2950

merged 1 commit into from
Apr 11, 2018

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Feb 7, 2018 •
edited
Loading

Summary

Solution for #2949

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

If your pull request is in reference to one or more open GitHub issues, please mention them here to keep the conversations linked together.

@tjschuck tjschuck requested a review from a team February 7, 2018 17:36
@adunkman adunkman merged commit 7e2feb6 into master Apr 11, 2018
@adunkman adunkman deleted the empty-style-attr branch April 11, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koenpunt @stof @adunkman