Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: lock to prevent event race conditions (issue #55) #56

Merged
merged 2 commits into from
Nov 18, 2015

Conversation

peterazmanov
Copy link
Contributor

issue #55

@harvimt
Copy link
Owner

harvimt commented Nov 18, 2015

Qt always uses real OS threads under the hood, but for consistency (since we're using QThreads). I feel like you should use Qt thread locks: see: http://doc.qt.io/qt-5/threads.html.
though maybe that would make the implementation more complicated (since the Qt versions don't support being used as a context manager)

harvimt added a commit that referenced this pull request Nov 18, 2015
bug fix: lock to prevent event race conditions (issue #55)
@harvimt harvimt merged commit 480ab82 into harvimt:master Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants