Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our markdown implementation to align with markdown-it-py==3.0.0 #1829

Closed
3 tasks done
miteshashar opened this issue Jul 28, 2023 · 0 comments · Fixed by #1835
Closed
3 tasks done

Upgrade our markdown implementation to align with markdown-it-py==3.0.0 #1829

miteshashar opened this issue Jul 28, 2023 · 0 comments · Fixed by #1835

Comments

@miteshashar
Copy link
Contributor

miteshashar commented Jul 28, 2023

Validate/compare our code and plugins against the following to make relevant changes:

funnel/utils/markdown/mdit_plugins/heading_anchors_fix.py:45: error: Argument 3 to "after" of "Ruler" has incompatible type "Callable[[StateInline], None]"; expected "Callable[[StateCore], None]"  [arg-type]
funnel/utils/markdown/mdit_plugins/abbr.py:145: error: Argument 3 to "after" of "Ruler" has incompatible type "Callable[[StateInline], None]"; expected "Callable[[StateCore], None]"  [arg-type]
funnel/utils/markdown/mdit_plugins/toc.py:259: error: Argument 2 to "push" of "Ruler" has incompatible type "Callable[[StateInline], Any]"; expected "Callable[[StateCore], None]"  [arg-type]
funnel/utils/markdown/base.py:145: error: Argument 2 to "MarkdownIt" has incompatible type "dict[Literal['html', 'breaks', 'linkify', 'typographer'], bool]"; expected "Mapping[str, Any] | None"  [arg-type]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant