Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json messaging format #1070

Merged
merged 5 commits into from
Jun 17, 2024
Merged

json messaging format #1070

merged 5 commits into from
Jun 17, 2024

Conversation

feds01
Copy link
Contributor

@feds01 feds01 commented Jun 7, 2024

  • pipeline: move metrics implementation out of hash-driver
  • logging: add JSON output format
  • driver: use new Metrics type for profiling
  • messaging: use CompilerOutputMessage for log::info!s
  • driver: add configuration for messaging format

feds01 added 5 commits June 6, 2024 13:07
@feds01
pipeline: move metrics implementation out of hash-driver
318c893
@feds01
logging: add JSON output format
6345b67
@feds01
driver: use new Metrics type for profiling
259903f
@feds01
messaging: use CompilerOutputMessage for log::info!s
d90388a 
This commit makes it that when `log::info!` displays data, that it
always goes through the `CompilerOutputMessage` format. This is so
that the outside message consumers always know the schema and hence
the format of the messages.

Also, added `@@Messaging` to places where they should emit `CompilerOutputMessages`s
when the format is decided.
@feds01
driver: add configuration for messaging format
74bbf06
@feds01 feds01 self-assigned this Jun 7, 2024
@feds01 feds01 requested a review from kontheocharis June 7, 2024 12:49
kontheocharis
kontheocharis approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@kontheocharis kontheocharis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool!

@feds01 feds01 merged commit 5410ba7 into main Jun 17, 2024
1 check passed
@feds01 feds01 deleted the json-messaging-format branch June 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontheocharis kontheocharis kontheocharis approved these changes

Assignees

@feds01 feds01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feds01 @kontheocharis