Refactor and simplify syncingspan maps #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no inherit need for the `LocalSpanMap` to have an associated `source_id`. Instead, we can pass it in when we sync the `LocalSpanMap` with the `SpanMap`.
kontheocharis
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Description
This PR removes the
source_idfield from theLocalSpanMapstruct. This field was used to store thesource_idof the span that was being parsed, but it was not being used anywhere. This PR also ensures that we abort parsing type arguments when there is an actual error.## Commits
source_idfromLocalSpanMap