Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attributes: implement checking and handling of attributes #930

Merged
merged 31 commits into from
Aug 31, 2023
Merged

attributes: implement checking and handling of attributes #930

merged 31 commits into from
Aug 31, 2023

Conversation

feds01
Copy link
Contributor

@feds01 feds01 commented Aug 25, 2023 •
edited
Loading

  • attrs: introduce new crate and add Attribute representations
  • attrs: add AttrTyMap
  • ast: add initial code for running macro/attribute checks in hash-expand
  • core: more dependency cleanups
  • parser: don't include macros in parent span of macro-able items
  • tir: use From<...> for implementing conversion to Lit kinds
  • ir: use attr_store() for attributes and add Instance::has_attr
  • core: rename CompilerStageKind::DeSugar to CompilerStageKind::Expand
  • untyped-semantics: cleanup old code, and remove commented out directive checking code
  • tir: register more AstNodeIds to items, specifically sequences of ids
  • hash-tir: improve ParamError diagnostic messages
  • expand: implement attribute checking
  • expand: correctly apply attrs on attribute subject
  • attrs: implement attribute specific error/warning checking and hookup to expand
  • tir: move primitives.rs into hash-tir from `hash-intrinsics
  • tir: introduce HasNodeId and re-implement directive handling
  • parser: fix improper span on grouped macro invocations
  • target: introduce HasTarget trait to query current target() from any implementor
  • lower: re-implement #layout_of
  • lower: implement applying repr and add discriminant option
  • lower: re-implement #dump_ir

closes #924
closes #925
closes #926
closes #927
closes #896
closes #915

@feds01 feds01 self-assigned this Aug 25, 2023
@feds01 feds01 requested a review from kontheocharis August 25, 2023 20:08
@feds01 feds01 added core Relating to the core internals of the compiler. language Issues that are language/compiler wide landmark labels Aug 25, 2023
kontheocharis
kontheocharis reviewed Aug 26, 2023
View reviewed changes
compiler/hash-attrs/src/target.rs Outdated Show resolved Hide resolved
compiler/hash-attrs/src/target.rs Show resolved Hide resolved
compiler/hash-attrs/src/target.rs Outdated Show resolved Hide resolved
compiler/hash-attrs/src/target.rs Outdated Show resolved Hide resolved
compiler/hash-attrs/src/target.rs Show resolved Hide resolved
compiler/hash-attrs/src/ty.rs Outdated Show resolved Hide resolved
compiler/hash-attrs/src/ty.rs Outdated Show resolved Hide resolved
compiler/hash-attrs/src/ty.rs Outdated Show resolved Hide resolved
compiler/hash-codegen/src/symbols/mangle.rs Outdated Show resolved Hide resolved
@feds01 feds01 requested a review from kontheocharis August 28, 2023 17:30
feds01 added 22 commits August 31, 2023 09:24
@feds01
attrs: introduce new crate and add Attribute representations
14e2fef
@feds01
attrs: add AttrTyMap
564a9fc 
The `AttrTyMap` is used to store metadata about builtin compiler attributes.
This information is used to check that the attributes are used correctly.
@feds01
ast: add initial code for running macro/attribute checks in `hash-exp…
eac3552 
…and`
@feds01
core: more dependency cleanups
fd5dcb4
@feds01
parser: don't include macros in parent span of macro-able items
d0d7a84
@feds01
tir: use From<...> for implementing conversion to Lit kinds
dfae974
@feds01
ir: use attr_store() for attributes and add Instance::has_attr
978fd8f
@feds01
core: rename CompilerStageKind::DeSugar to CompilerStageKind::Expand
5f78881
@feds01
untyped-semantics: cleanup old code, and remove commented out directi…
3bf5c7b 
…ve checking code
@feds01
tir: register more AstNodeIds to items, specifically sequences of ids
2c11be3 
Additionally, introduce a `AstNodeId::null()` which is used to represent
a null-node which is never taken up by any other node, and is used
to represent the absence of a node.
@feds01
hash-tir: improve ParamError diagnostic messages
aa862c6
@feds01
expand: implement attribute checking
50ac4ad
@feds01
expand: correctly apply attrs on attribute subject
3fef847
@feds01
attrs: implement attribute specific error/warning checking and hookup…
4d2d880 
… to expand
@feds01
tir: move primitives.rs into hash-tir from `hash-intrinsics
e89ba84
@feds01
tir: introduce HasNodeId and re-implement directive handling
f08503e 
`HasNodeId` is a helper trait which specifies that a certain type
has an associated node-id on it, and hence `node_id()` can be
called to retrieve it. This is useful for things like `TermId`,
`FnDefId`, `Pat`, etc.

With this change, handling of `#run`, `#dump_tir`, `#pure`,
`#entry_point` have been re-implemented.

Additionally, lots of code cleanup around other places because
of this change.
@feds01
parser: fix improper span on grouped macro invocations
af6c64d
@feds01
target: introduce HasTarget trait to query current target() from …
9c0d15c 
…any implementor
@feds01
lower: re-implement #layout_of
ce86535
@feds01
lower: implement applying repr and add discriminant option
a84d291 
This patch reworks the way `repr` attributes are checked by
introducing a `hash-attrs` specific `ReprAttr` representation
which is parsed from a `Attr`. During parsing, various semantic
checks are perfomed, and can be emitted to the `AttrChecker`.

Additionally, this logic is re-used in `hash-lower` to actually
apply the attribute onto `Adt`s that specify a representation
attribute.

Furthemore, since `repr` supports `u8`, `u16`, ...  as well, this
meant that `discriminant` option on `AdtRepresentation` is now
also supported.
@feds01
lower: re-implement #dump_ir
f0319e1
@feds01
address pr comments
6fa15e8
kontheocharis
kontheocharis previously approved these changes Aug 31, 2023
View reviewed changes
@feds01 feds01 requested a review from kontheocharis August 31, 2023 14:27
@feds01 feds01 merged commit 60f64dd into main Aug 31, 2023
1 check passed
@feds01 feds01 deleted the attrs branch August 31, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontheocharis kontheocharis kontheocharis approved these changes

Assignees

@feds01 feds01

Labels
core Relating to the core internals of the compiler. landmark language Issues that are language/compiler wide
Projects
None yet
Milestone
No milestone
2 participants
@feds01 @kontheocharis