Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organise TIR into folders #977

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Organise TIR into folders #977

merged 4 commits into from
Sep 14, 2023

Conversation

kontheocharis
Copy link
Collaborator

Closes #945

@kontheocharis kontheocharis added type-system Issues related with typechecking sub-system. organisation labels Sep 14, 2023
@kontheocharis kontheocharis self-assigned this Sep 14, 2023
feds01
feds01 reviewed Sep 14, 2023
View reviewed changes
compiler/hash-tir/src/nodes/mod.rs Outdated Show resolved Hide resolved
compiler/hash-tir/src/nodes/mod.rs Outdated Show resolved Hide resolved
compiler/hash-tir/src/nodes/terms/mod.rs Outdated Show resolved Hide resolved
compiler/hash-tir/src/nodes/mod.rs Outdated Show resolved Hide resolved
feds01
feds01 previously approved these changes Sep 14, 2023
View reviewed changes
feds01
feds01 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@feds01 feds01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, -220 lines is a benefit too

@kontheocharis kontheocharis merged commit 9c56d6a into main Sep 14, 2023
1 check passed
@feds01 feds01 deleted the folders branch September 22, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feds01 feds01 feds01 approved these changes

Assignees

@kontheocharis kontheocharis

Labels
organisation type-system Issues related with typechecking sub-system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganise the TIR into folders
2 participants
@kontheocharis @feds01