exhaustiveness: speedup checking 3x-5x #987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings speedups of exhaustiveness from 3x-5x by the following changes:
This PR switches the internal exhaustiveness stores to just use
Vec
s over theStore
interface. This avoids the locking mechanism for stores which never need to be locked.Additionally, this also switches
Fields
to use aThinVec
over aVec
which leads to better performance and less memory use overall.Finally, we don't need to store the
bias
on anIntRange
directly, only when we need to convert back into normal values, so remove it from theIntRange
struct.In addition to performance improvements, the analysis phase now records the time taken for exhaustiveness to complete its operations, and reports them through the standard compiler metrics plumbing.