Add ledger_id to entity info responses #159
Replies: 5 comments 1 reply
-
|
@tinker-michaelj we would like to get your feedback on how we would handle the ledger_id for a custom network. A custom network would be something that users would spin up locally. @DSMatusevich suggestion was the following: cc: @DSMatusevich |
Beta Was this translation helpful? Give feedback.
-
|
Why |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your question @bugbytesinc! This was specified by @lbaird as it has to do with state proofs. State proofs I believe will contain the |
Beta Was this translation helpful? Give feedback.
-
|
The ledger ID will be a byte array (so it’s of type “bytes”).
For the current HIP defining checksums, the byte array is a single byte. In
the near future, it will change to be 48 bytes (a SHA-384 hash), but may
expand to slightly longer in the near future.
The ledger ID can’t be a simple integer, because it is the root of the
state proof. So it needs to be large enough to hold a hash or public key
that can provide trust in the state proof.
…On Fri, Oct 15, 2021 at 12:27 PM SimiHunjan ***@***.***> wrote:
Thank you for your question @bugbytesinc <https://github.com/bugbytesinc>!
This was specified by @lbaird <https://github.com/lbaird> as it has to do
with state proofs. State proofs I believe will contain the ledger_id and
it will be 48 bytes. @lbaird <https://github.com/lbaird> might be able to
help further clarify here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDBYW3A736FCAGLSJOOEPDUHBQBDANCNFSM5F3ZFHFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Beta Was this translation helpful? Give feedback.
-
|
So there is one root of the state proof per ledger? Are those values know already? Does that mean previewnet will frequently change it's value? |
Beta Was this translation helpful? Give feedback.
-
|
There is one per ledger. Previewnet can keep a constant ledger ID. Or it
could change with each reset. I think it’s simplest for users if we keep it
unchanged through all updates.
…On Fri, Oct 15, 2021 at 4:36 PM Danno Ferrin ***@***.***> wrote:
So there is one root of the state proof per ledger? Are those values know
already? Does that mean previewnet will frequently change it's value?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDBYWYF6EIZVDQZCSXAOF3UHCNEVANCNFSM5F3ZFHFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Beta Was this translation helpful? Give feedback.
-
Abstract
Proposal to add a network ID field to info responses for all entities.
Motivation
In the Hedera Transaction Tool application, users will have the ability to request account infos for accounts on previewnet, testnet, mainnet or a custom network.
You can then take the response, write it to a file, and distribute that file for others to update that account's information.
Since you can request account infos from multiple different networks you can't tell which network the response came from the file the response is stored in unless the user who requested it forwards that information to the other users.
Rationale
To solve this issue, we think it would make sense for all enitity info responses to include a
ledger_idfield where00= represents mainnet,01represents testnet, and02represents previewnet. Custom networks will be represented by an integer that can be calculated from the node IPs.User Stories
As a developer I want to know which network the info response came from when the response information is written to a file that is then shared with other users of the application.
Specification
HAPI Changes
Accounts
message AccountInfo { /** * The account ID for which this information applies */ AccountID accountID = 1; /** * The Contract Account ID comprising of both the contract instance and the cryptocurrency * account owned by the contract instance, in the format used by Solidity */ string contractAccountID = 2; /** * If true, then this account has been deleted, it will disappear when it expires, and all * transactions for it will fail except the transaction to extend its expiration date */ bool deleted = 3; /** * The Account ID of the account to which this is proxy staked. If proxyAccountID is null, * or is an invalid account, or is an account that isn't a node, then this account is * automatically proxy staked to a node chosen by the network, but without earning payments. * If the proxyAccountID account refuses to accept proxy staking , or if it is not currently * running a node, then it will behave as if proxyAccountID was null. */ AccountID proxyAccountID = 4; /** * The total number of tinybars proxy staked to this account */ int64 proxyReceived = 6; /** * The key for the account, which must sign in order to transfer out, or to modify the * account in any way other than extending its expiration date. */ Key key = 7; /** * The current balance of account in tinybars */ uint64 balance = 8; /** * [Deprecated]. The threshold amount, in tinybars, at which a record is created of any * transaction that decreases the balance of this account by more than the threshold */ uint64 generateSendRecordThreshold = 9 [deprecated=true]; /** * [Deprecated]. The threshold amount, in tinybars, at which a record is created of any * transaction that increases the balance of this account by more than the threshold */ uint64 generateReceiveRecordThreshold = 10 [deprecated=true]; /** * If true, no transaction can transfer to this account unless signed by this account's key */ bool receiverSigRequired = 11; /** * The TimeStamp time at which this account is set to expire */ Timestamp expirationTime = 12; /** * The duration for expiration time will extend every this many seconds. If there are * insufficient funds, then it extends as long as possible. If it is empty when it expires, * then it is deleted. */ Duration autoRenewPeriod = 13; /** * All of the livehashes attached to the account (each of which is a hash along with the * keys that authorized it and can delete it) */ repeated LiveHash liveHashes = 14; /** * All tokens related to this account */ repeated TokenRelationship tokenRelationships = 15; /** * The memo associated with the account */ string memo = 16; /** * The number of NFTs owned by this account */ int64 ownedNfts = 17; /** * The maximum number of tokens that an Account can be implicitly associated with. */ int32 max_automatic_token_associations = 18; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 19; }Tokens
message TokenInfo { /** * ID of the token instance */ TokenID tokenId = 1; /** * The name of the token. It is a string of ASCII only characters */ string name = 2; /** * The symbol of the token. It is a UTF-8 capitalized alphabetical string */ string symbol = 3; /** * The number of decimal places a token is divisible by. Always 0 for tokens of type * NON_FUNGIBLE_UNIQUE */ uint32 decimals = 4; /** * For tokens of type FUNGIBLE_COMMON - the total supply of tokens that are currently in * circulation. For tokens of type NON_FUNGIBLE_UNIQUE - the number of NFTs created of this * token instance */ uint64 totalSupply = 5; /** * The ID of the account which is set as Treasury */ AccountID treasury = 6; /** * The key which can perform update/delete operations on the token. If empty, the token can be * perceived as immutable (not being able to be updated/deleted) */ Key adminKey = 7; /** * The key which can grant or revoke KYC of an account for the token's transactions. If empty, * KYC is not required, and KYC grant or revoke operations are not possible. */ Key kycKey = 8; /** * The key which can freeze or unfreeze an account for token transactions. If empty, freezing is * not possible */ Key freezeKey = 9; /** * The key which can wipe token balance of an account. If empty, wipe is not possible */ Key wipeKey = 10; /** * The key which can change the supply of a token. The key is used to sign Token Mint/Burn * operations */ Key supplyKey = 11; /** * The default Freeze status (not applicable, frozen or unfrozen) of Hedera accounts relative to * this token. FreezeNotApplicable is returned if Token Freeze Key is empty. Frozen is returned * if Token Freeze Key is set and defaultFreeze is set to true. Unfrozen is returned if Token * Freeze Key is set and defaultFreeze is set to false */ TokenFreezeStatus defaultFreezeStatus = 12; /** * The default KYC status (KycNotApplicable or Revoked) of Hedera accounts relative to this * token. KycNotApplicable is returned if KYC key is not set, otherwise Revoked */ TokenKycStatus defaultKycStatus = 13; /** * Specifies whether the token was deleted or not */ bool deleted = 14; /** * An account which will be automatically charged to renew the token's expiration, at * autoRenewPeriod interval */ AccountID autoRenewAccount = 15; /** * The interval at which the auto-renew account will be charged to extend the token's expiry */ Duration autoRenewPeriod = 16; /** * The epoch second at which the token will expire */ Timestamp expiry = 17; /** * The memo associated with the token */ string memo = 18; /** * The token type */ TokenType tokenType = 19; /** * The token supply type */ TokenSupplyType supplyType = 20; /** * For tokens of type FUNGIBLE_COMMON - The Maximum number of fungible tokens that can be in * circulation. For tokens of type NON_FUNGIBLE_UNIQUE - the maximum number of NFTs (serial * numbers) that can be in circulation */ int64 maxSupply = 21; /** * The key which can change the custom fee schedule of the token; if not set, the fee schedule * is immutable */ Key fee_schedule_key = 22; /** * The custom fees to be assessed during a CryptoTransfer that transfers units of this token */ repeated CustomFee custom_fees = 23; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 24; }Topics
message ConsensusTopicInfo { /** * The memo associated with the topic (UTF-8 encoding max 100 bytes) */ string memo = 1; /** * When a topic is created, its running hash is initialized to 48 bytes of binary zeros. * For each submitted message, the topic's running hash is then updated to the output * of a particular SHA-384 digest whose input data include the previous running hash. * * See the TransactionReceipt.proto documentation for an exact description of the * data included in the SHA-384 digest used for the update. */ bytes runningHash = 2; /** * Sequence number (starting at 1 for the first submitMessage) of messages on the topic. */ uint64 sequenceNumber = 3; /** * Effective consensus timestamp at (and after) which submitMessage calls will no longer succeed on the topic * and the topic will expire and after AUTORENEW_GRACE_PERIOD be automatically deleted. */ Timestamp expirationTime = 4; /** * Access control for update/delete of the topic. Null if there is no key. */ Key adminKey = 5; /** * Access control for ConsensusService.submitMessage. Null if there is no key. */ Key submitKey = 6; /** * If an auto-renew account is specified, when the topic expires, its lifetime will be extended * by up to this duration (depending on the solvency of the auto-renew account). If the * auto-renew account has no funds at all, the topic will be deleted instead. */ Duration autoRenewPeriod = 7; /** * The account, if any, to charge for automatic renewal of the topic's lifetime upon expiry. */ AccountID autoRenewAccount = 8; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 9; }Files
message FileInfo { /** * The file ID of the file for which information is requested */ FileID fileID = 1; /** * Number of bytes in contents */ int64 size = 2; /** * The current time at which this account is set to expire */ Timestamp expirationTime = 3; /** * True if deleted but not yet expired */ bool deleted = 4; /** * One of these keys must sign in order to modify or delete the file */ KeyList keys = 5; /** * The memo associated with the file */ string memo = 6; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 7; }Smart Contracts
message ContractInfo { /** * ID of the contract instance, in the format used in transactions */ ContractID contractID = 1; /** * ID of the cryptocurrency account owned by the contract instance, in the format used in * transactions */ AccountID accountID = 2; /** * ID of both the contract instance and the cryptocurrency account owned by the contract * instance, in the format used by Solidity */ string contractAccountID = 3; /** * the state of the instance and its fields can be modified arbitrarily if this key signs a * transaction to modify it. If this is null, then such modifications are not possible, and * there is no administrator that can override the normal operation of this smart contract * instance. Note that if it is created with no admin keys, then there is no administrator * to authorize changing the admin keys, so there can never be any admin keys for that * instance. */ Key adminKey = 4; /** * the current time at which this contract instance (and its account) is set to expire */ Timestamp expirationTime = 5; /** * the expiration time will extend every this many seconds. If there are insufficient funds, * then it extends as long as possible. If the account is empty when it expires, then it is * deleted. */ Duration autoRenewPeriod = 6; /** * number of bytes of storage being used by this instance (which affects the cost to extend * the expiration time) */ int64 storage = 7; /** * the memo associated with the contract (max 100 bytes) */ string memo = 8; /** * The current balance, in tinybars */ uint64 balance = 9; /** * Whether the contract has been deleted */ bool deleted = 10; /** * The tokens associated to the contract */ repeated TokenRelationship tokenRelationships = 11; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 12; }Schedule
message ScheduleInfo { /** * The id of the schedule */ ScheduleID scheduleID = 1; oneof data { /** * If the schedule has been deleted, the consensus time when this occurred */ Timestamp deletion_time = 2; /** * If the schedule has been executed, the consensus time when this occurred */ Timestamp execution_time = 3; } /** * The time at which the schedule will expire */ Timestamp expirationTime = 4; /** * The scheduled transaction */ SchedulableTransactionBody scheduledTransactionBody = 5; /** * The publicly visible memo of the schedule */ string memo = 6; /** * The key used to delete the schedule from state */ Key adminKey = 7; /** * The Ed25519 keys the network deems to have signed the scheduled transaction */ KeyList signers = 8; /** * The id of the account that created the schedule */ AccountID creatorAccountID = 9; /** * The id of the account responsible for the service fee of the scheduled transaction */ AccountID payerAccountID = 10; /** * The transaction id that will be used in the record of the scheduled transaction (if it * executes) */ TransactionID scheduledTransactionID = 11; + /** + * The ledger ID the response was returned from (00=mainnet, 01=testnet, 02=previewnet) + */ + bytes ledger_id = 9; }Backwards Compatibility
This change should be backwards compatible as it returns an extra field in a response, but does not modify an existing field.
Security Implications
N/A
How to Teach This
Reference Implementation
N/A
Rejected Ideas
N/A
Open Issues
References
Copyright/license
This document is licensed under the Apache License, Version 2.0 -- see LICENSE or (https://www.apache.org/licenses/LICENSE-2.0)
Beta Was this translation helpful? Give feedback.
All reactions