-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create hip-1021 #1021
feat: create hip-1021 #1021
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
This HIP proposes a modification to the Hedera Consensus Service (HCS) to: | ||
- Enable setting the `autoRenewAccountId` to the account creating a `TopicCreateTransaction` when an Admin Key is not present during Topic Creation. | ||
- It ensures that for all existing topics with only a Submit Key and no `autoRenewAccountId`, the original `payer_account_id` of the topic is retroactively set as the `autoRenewAccountId`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not modify existing topics IMO:
- We usually do not modify existing entities. A user may have left autoRenewAccount empty intentionally and disagrees with this change.
- This would have to be initiated outside of the consensus node because the consensus node does not store the original
payer_account_id
. - It is unclear who should pay for these transactions.
This HIP proposes a modification to the Hedera Consensus Service (HCS) to: | ||
- Enable setting the `autoRenewAccountId` to the account creating a `TopicCreateTransaction` when an Admin Key is not present during Topic Creation. | ||
- It ensures that for all existing topics with only a Submit Key and no `autoRenewAccountId`, the original `payer_account_id` of the topic is retroactively set as the `autoRenewAccountId`. | ||
- Automatically set the `autoRenewAccountId` to the `payer_account_id` of the Topic Id to prevent unintended user error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would I be able to leave this field empty intentionally?
Another solution could be to set this as a default in the SDKs. This would give me a similar experience, but I would still be able to clear the autoRenewAccountId
.
Signed-off-by: Michael Garber <michael.garber@swirldslabs.com>
Signed-off-by: Michael Garber <michael.garber@swirldslabs.com>
This reverts commit 438df38.
Description
This pull request introduces HIP-1021, titled "Improve Assignment of Auto-Renew Account ID for Topics." The proposal aims to enhance the Hedera Consensus Service (HCS) by automating the assignment of the
autoRenewAccountId
to the account that creates aTopicCreateTransaction
. This feature is particularly useful when an Admin Key is not present during topic creation, ensuring that the auto-renewal mechanism is consistently applied.The key changes include:
autoRenewAccountId
will automatically be set to thepayer_account_id
of the transaction if an Admin Key is not provided during topic creation.autoRenewAccountId
, the originalpayer_account_id
will be retroactively set as theautoRenewAccountId
.Improvements
Automatic Setting of Renewal Account:
Uniform Handling of Old Topics:
Fewer Mistakes:
Easier for Users:
Ready for Future Changes: