Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-991 update according to latest discussion #1079

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

HIP-991 update according to latest discussion #1079

wants to merge 9 commits into from

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Nov 14, 2024

Description:

This PR modifies the HIP according to the latest discussion:

  • Removed allowance (This will be handled in a later HIP.)
  • Added max_custom_fee instead

@netopyr
Removed allowance (will be handled in a later HIP), added max_custom_…
3273aeb 
…fee instead

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr self-assigned this Nov 14, 2024
@netopyr netopyr requested a review from mgarbs as a code owner November 14, 2024 11:36
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 2df847c
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/6751e4dd7c116c000805883a
😎 Deploy Preview https://deploy-preview-1079--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ty-swirldslabs
ty-swirldslabs reviewed Nov 14, 2024
View reviewed changes
HIP/hip-991.md Outdated Show resolved Hide resolved
@netopyr
Added max_custom_fees flag
533c56f 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr requested review from ty-swirldslabs, Neurone, jasperpotts and rbair23 and removed request for ty-swirldslabs November 15, 2024 11:54
@netopyr
Fixed update date and working-group
aec0e78 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
vtronkov
vtronkov reviewed Nov 18, 2024
View reviewed changes
HIP/hip-991.md Outdated Show resolved Hide resolved
vtronkov
vtronkov reviewed Nov 18, 2024
View reviewed changes
HIP/hip-991.md Outdated Show resolved Hide resolved
@vtronkov
Copy link

There are a few more mentions of "allowances" in the Mirror Node and SDK Reference Implementation sections. You can remove those.

@netopyr
Some clarifications
fb13c6c 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
vtronkov
vtronkov reviewed Nov 26, 2024
View reviewed changes
HIP/hip-991.md Outdated Show resolved Hide resolved
@netopyr
Merge branch 'main' into hip-991-update
2ac2b5b 
* main:
  Daily rewards for active nodes (#1064)
  HIP-980: Add shadow fork support as a rejected idea (#1058)
  Update HIP-904 status and HSCS details (#1080)
@netopyr
Removed FEKL acronym
d393a3c 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr requested a review from vtronkov December 4, 2024 08:36
@netopyr
Updated date
25567b0 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr
Removed allowance from Mirror Node and SDK section
24d5157 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
vtronkov
vtronkov approved these changes Dec 4, 2024
View reviewed changes
Copy link

@vtronkov vtronkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@netopyr
Minor fix
2df847c 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtronkov vtronkov vtronkov approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@Neurone Neurone Neurone approved these changes

@mgarbs mgarbs Awaiting requested review from mgarbs mgarbs is a code owner

@jasperpotts jasperpotts Awaiting requested review from jasperpotts

@rbair23 rbair23 Awaiting requested review from rbair23

@ty-swirldslabs ty-swirldslabs Awaiting requested review from ty-swirldslabs

At least 1 approving review is required to merge this pull request.

Assignees

@netopyr netopyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@netopyr @vtronkov @Neurone @steven-sheehy @ty-swirldslabs